Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1464189

[PATCH next-next 0/2] qdisc-hashtable fixes

Show all headers | View raw

The following two patches fix all the issues that have been reported 
against the conversion of qdisc linked list to hashtable (currently in 
net-next) so far.

First patch adjusts handling of singleton qdiscs to the new semantics, and 
is rather straightforward.

The second patch, which fixes "cosmetic" issue of duplicate entries in the 
qdisc dump for ingress qdiscs, is a little bit more hairy; I personally 
would love to see all the already existing "if (ingress)"-like hacks go 
away (by, let's say, introducing a general TCQ_F_? flag), but that's way 
out of scope of this patchset (but already on my todo).

Thanks a lot to Daniel Borkmann and David Ahern for reporting the issues 
and testing the patches promptly.

Jiri Kosina (2):
      net: sched: fix handling of singleton qdiscs with qdisc_hash
      net: sched: avoid duplicates in qdisc dump

 net/sched/sch_api.c | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH next-next 0/2] qdisc-hashtable fixes Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
  [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
    Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Cong Wang <xiyou.wangcong@gmail.com> - 2016-08-19 03:50 +0200
      Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Jiri Kosina <jikos@kernel.org> - 2016-08-19 23:50 +0200
  [PATCH 1/2] net: sched: fix handling of singleton qdiscs with  qdisc_hash Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
  Re: [PATCH next-next 0/2] qdisc-hashtable fixes David Miller <davem@davemloft.net> - 2016-08-19 06:20 +0200

csiph-web