Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1465833

Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump

Show all headers | View raw

On Tue, Aug 16, 2016 at 2:53 PM, Jiri Kosina <jikos@kernel.org> wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> tc_dump_qdisc() performs dumping of the per-device qdiscs in two phases;
> first, the "standard" dev->qdisc is being dumped. Second, if there is/are
> ingress queue(s), they are being dumped as well.
>
> After conversion of netdevice's qdisc linked-list into hashtable, these
> two sets are not in two disjunctive sets/lists any more, but are both
> "reachable" directly from netdevice's hashtable. As a consequence, the
> "full-depth" dump of the ingress qdiscs results in immediately hitting the
> netdevice hashtable again, and duplicating the dump that has already been
> performed for dev->qdisc.
> What in fact needs to be dumped in case of ingress queue is "just" the
> top-level ingress qdisc, as everything else has been dumped already.

Doesn't this mean we can now just remove the ingress case from
tc_dump_qdisc() and simply iterate the whole hash table?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH next-next 0/2] qdisc-hashtable fixes Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
  [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
    Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Cong Wang <xiyou.wangcong@gmail.com> - 2016-08-19 03:50 +0200
      Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Jiri Kosina <jikos@kernel.org> - 2016-08-19 23:50 +0200
  [PATCH 1/2] net: sched: fix handling of singleton qdiscs with  qdisc_hash Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
  Re: [PATCH next-next 0/2] qdisc-hashtable fixes David Miller <davem@davemloft.net> - 2016-08-19 06:20 +0200

csiph-web