Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463211

Re: Building a subdirectory ignores parent subdir-ccflags

Show all headers | View raw

Dne 15.8.2016 v 23:29 Joe Perches napsal(a):
> On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote:
>> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
>>> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
>>>> Start to rationalize include paths in source code files.
>> []
>>>> diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
>> []
>>>> @@ -1,2 +1,5 @@
>>>> +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/include/
>>>> +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/lustre/include/
>>>> +
>>>>  obj-$(CONFIG_LNET)		+= lnet/
>>>>  obj-$(CONFIG_LUSTRE_FS)		+= lustre/
>>> This is good, but does this break the subdir make command:
>>> 	make M=drivers/staging/lustre/foo_dir/
>>> ?
>> hmm, yeah, it does.  Oh well, nevermind for awhile.
>>> I remember the last time I tried to clean this up, it took a while...
>> It seems like something the build tools should
>> handle correctly now, but I'll look at it.
> 
> Perhaps making a specific directory should also walk up
> any parent directory Makefiles looking for subdir flags.
> 
> Is that unreasonable?  Any suggestions?

I suggest to do make drivers/staging/lustre/. If building the lustre
subdirectories is going to be a common use case, then you can propagate
the subdir-ccflags-y assignment down to the individual Makefiles.

Michal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] staging: lustre: #include neatening Joe Perches <joe@perches.com> - 2016-08-15 21:40 +0200
  [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-15 21:40 +0200
    Re: [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to  Makefile James Simmons <jsimmons@infradead.org> - 2016-08-15 23:10 +0200
    Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-15 23:10 +0200
      Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-15 23:20 +0200
        Building a subdirectory ignores parent subdir-ccflags (was: Re:  [PATCH 1/2] staging: lustre: Add include path to Makefile) Joe Perches <joe@perches.com> - 2016-08-15 23:30 +0200
          Re: Building a subdirectory ignores parent subdir-ccflags Michal Marek <mmarek@suse.com> - 2016-08-16 00:10 +0200
            Re: Building a subdirectory ignores parent subdir-ccflags Joe Perches <joe@perches.com> - 2016-08-16 00:50 +0200
        Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-16 13:00 +0200
          Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-16 13:10 +0200

csiph-web