Re: Building a subdirectory ignores parent subdir-ccflags

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: Building a subdirectory ignores parent subdir-ccflags
Date	2016-08-16 00:50 +0200
Message-ID	<s6yRH-3f5-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <s6vTQ-1iQ-29@gated-at.bofh.it> <s6xiW-2lI-7@gated-at.bofh.it> <s6xsB-2qu-17@gated-at.bofh.it> <s6xCi-2w3-23@gated-at.bofh.it> <s6yf0-327-55@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote:

Hi Michal.

> > Perhaps making a specific directory should also walk up
> > any parent directory Makefiles looking for subdir flags.
> > 
> > Is that unreasonable?  Any suggestions?
> I suggest to do make drivers/staging/lustre/. If building the lustre
> subdirectories is going to be a common use case, then you can propagate
> the subdir-ccflags-y assignment down to the individual Makefiles.

I don't have a problem with that.

Others might though for whatever reason.

There are a couple other places in the tree that
also use subdir-ccflags where the results of making
a subdirectory would either fail or have unexpected
results.

Does it matter?  Not much, but it could be nicer if
it's possible for parent Makefile paths to be ascended.

I'm not much of a Makefile person, but perhaps you have
some clues/tips/suggestions for implementation?

Thread

[PATCH 0/2] staging: lustre: #include neatening Joe Perches <joe@perches.com> - 2016-08-15 21:40 +0200
  [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-15 21:40 +0200
    Re: [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to  Makefile James Simmons <jsimmons@infradead.org> - 2016-08-15 23:10 +0200
    Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-15 23:10 +0200
      Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-15 23:20 +0200
        Building a subdirectory ignores parent subdir-ccflags (was: Re:  [PATCH 1/2] staging: lustre: Add include path to Makefile) Joe Perches <joe@perches.com> - 2016-08-15 23:30 +0200
          Re: Building a subdirectory ignores parent subdir-ccflags Michal Marek <mmarek@suse.com> - 2016-08-16 00:10 +0200
            Re: Building a subdirectory ignores parent subdir-ccflags Joe Perches <joe@perches.com> - 2016-08-16 00:50 +0200
        Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-16 13:00 +0200
          Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-16 13:10 +0200

csiph-web