Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463684

Re: [PATCH 1/2] staging: lustre: Add include path to Makefile

Show all headers | View raw

On Mon, Aug 15, 2016 at 02:14:18PM -0700, Joe Perches wrote:
> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > > Start to rationalize include paths in source code files.
> []
> > > diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
> []
> > > @@ -1,2 +1,5 @@
> > > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/include/
> > > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/lustre/include/
> > > +
> > >  obj-$(CONFIG_LNET)		+= lnet/
> > >  obj-$(CONFIG_LUSTRE_FS)		+= lustre/
> > This is good, but does this break the subdir make command:
> > 	make M=drivers/staging/lustre/foo_dir/
> > ?
> 
> hmm, yeah, it does.  Oh well, nevermind for awhile.
> 
> > I remember the last time I tried to clean this up, it took a while...
> 
> It seems like something the build tools should
> handle correctly now, but I'll look at it.

Nah, I think it's fine the way it is.  What's wrong with the "../" type
things in the include directives?  The build system works well with it,
you can build any single module or file correctly, and it's obvious what
the code is including from.

Now you might argue that the lustre code shouldn't have such a mess of
include files like this, and I would totally agree.  I suggest working
on reducing the number of .h files they have, and centralizing them such
that all of these cross-directory includes aren't needed anymore either
in the build directives, or in the .c files.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] staging: lustre: #include neatening Joe Perches <joe@perches.com> - 2016-08-15 21:40 +0200
  [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-15 21:40 +0200
    Re: [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to  Makefile James Simmons <jsimmons@infradead.org> - 2016-08-15 23:10 +0200
    Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-15 23:10 +0200
      Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-15 23:20 +0200
        Building a subdirectory ignores parent subdir-ccflags (was: Re:  [PATCH 1/2] staging: lustre: Add include path to Makefile) Joe Perches <joe@perches.com> - 2016-08-15 23:30 +0200
          Re: Building a subdirectory ignores parent subdir-ccflags Michal Marek <mmarek@suse.com> - 2016-08-16 00:10 +0200
            Re: Building a subdirectory ignores parent subdir-ccflags Joe Perches <joe@perches.com> - 2016-08-16 00:50 +0200
        Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-16 13:00 +0200
          Re: [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches <joe@perches.com> - 2016-08-16 13:10 +0200

csiph-web