Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1462510

Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs

Path csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From Andrew Jeffery <andrew@aj.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs
Date Mon, 15 Aug 2016 02:40:01 +0200
Message-ID <s6e6B-6RG-3@gated-at.bofh.it> (permalink)
References <rWSRH-69e-5@gated-at.bofh.it> <rWSRI-69e-27@gated-at.bofh.it> <s4TQC-1tP-25@gated-at.bofh.it> <s58FX-2QI-7@gated-at.bofh.it> <s5kxs-26U-15@gated-at.bofh.it> <s5w5z-1gM-3@gated-at.bofh.it>
X-Original-To Benjamin Herrenschmidt <benh@kernel.crashing.org>, Linus Walleij <linus.walleij@linaro.org>
Dkim-Signature v=1; a=rsa-sha1; c=relaxed/relaxed; d=aj.id.au; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=d4Wqf bma9x1jBWavpgFP/LtGvyI=; b=MtuoUbVFkM/XhOfL+WpPfETyCpELpYiVIDIE1 QT/XLU9efNJaq+Fx67w01Wvx8Ti3+xVWxvfcHCPfHy7jpQ43OmbQHlYYRlc8GR5z BiCsbDsPD4x0YS/9LBP8N/U4pKi7/LAQvgZKQ3dBgOWdU2ubJdNLkQ1DG1sJZ0W/ T5R390=
Dkim-Signature v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=d4Wqfbma9x1jBWavpgFP/LtGvyI=; b=H/L5c RzK7qSa7H2RPfe293wG4/Knu8EWbRRB7FaGwCAln6SepGaP8gBg/vmtv2hiLmBcJ oYEJF3JwBCttQLgnfpmTB47S5I7HTgwyz9/8sEePGejH7hdr3PIGlkx6WAzO8/Fg 0wBAPRtmG5rx3Vqa7nzkO+lT5v9YYIoe3saqRM=
X-Sasl-Enc JrxLySawVQslw7wNzYfRDhxClW46XdEG8+CStlVzuqhd 1471221423
Content-Type multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Kkmm5pzJ9XyCVSXgcQ3s"
X-Mailer Evolution 3.18.5.2-0ubuntu3
MIME-Version 1.0
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 50
Organization linux.* mail to news gateway
X-Original-Cc Alexandre Courbot <gnurou@gmail.com>, Joel Stanley <joel@jms.id.au>, Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>, Russell King <linux@armlinux.org.uk>, Jeremy Kerr <jk@ozlabs.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date Mon, 15 Aug 2016 10:06:52 +0930
X-Original-Message-ID <1471221412.27272.76.camel@aj.id.au>
X-Original-References <1468994313-13538-1-git-send-email-andrew@aj.id.au> <1468994313-13538-3-git-send-email-andrew@aj.id.au> <CACRpkdZ0p+jNHBV1AqhVWQ2Q8RRrHVfsAz3XU3_+f6My22=Zxg@mail.gmail.com> <1470962022.27272.68.camel@aj.id.au> <CACRpkdaN=wR4amskqMapTJzaTTMJZe2EQWRnyLMQkq_zuhr2eA@mail.gmail.com> <1471049894.12231.41.camel@kernel.crashing.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1462510

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Sat, 2016-08-13 at 10:58 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2016-08-12 at 15:18 +0200, Linus Walleij wrote:
> > 
> > I would probably prefer that option (introduce another field)
> > but you should make the overall decision, it's no strong opinion
> > from my side.
> > 
> > > 
> > > Would it be acceptable to document that requirement?
> It might make it a bit less nasty (and easier to change later on
> if necessary) to use some kind of:
> 
> 	bool ast_signal_is_gpio(...)
> 
> And stick the strcmp in there.

Yep, I'll do so for v2.

Cheers,

Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Linus Walleij <linus.walleij@linaro.org> - 2016-08-11 10:50 +0200
  Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Andrew Jeffery <andrew@aj.id.au> - 2016-08-12 02:40 +0200
    Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Linus Walleij <linus.walleij@linaro.org> - 2016-08-12 15:20 +0200
      Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-08-13 03:40 +0200
        Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Andrew Jeffery <andrew@aj.id.au> - 2016-08-15 02:40 +0200

csiph-web