Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs

From	Andrew Jeffery <andrew@aj.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs
Date	2016-08-15 02:40 +0200
Message-ID	<s6e6B-6RG-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <rWSRI-69e-27@gated-at.bofh.it> <s4TQC-1tP-25@gated-at.bofh.it> <s58FX-2QI-7@gated-at.bofh.it> <s5kxs-26U-15@gated-at.bofh.it> <s5w5z-1gM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, 2016-08-13 at 10:58 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2016-08-12 at 15:18 +0200, Linus Walleij wrote:
> > 
> > I would probably prefer that option (introduce another field)
> > but you should make the overall decision, it's no strong opinion
> > from my side.
> > 
> > > 
> > > Would it be acceptable to document that requirement?
> It might make it a bit less nasty (and easier to change later on
> if necessary) to use some kind of:
> 
> 	bool ast_signal_is_gpio(...)
> 
> And stick the strcmp in there.

Yep, I'll do so for v2.

Cheers,

Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Linus Walleij <linus.walleij@linaro.org> - 2016-08-11 10:50 +0200
  Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Andrew Jeffery <andrew@aj.id.au> - 2016-08-12 02:40 +0200
    Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Linus Walleij <linus.walleij@linaro.org> - 2016-08-12 15:20 +0200
      Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-08-13 03:40 +0200
        Re: [PATCH 02/12] pinctrl: Add core pinctrl support for Aspeed SoCs Andrew Jeffery <andrew@aj.id.au> - 2016-08-15 02:40 +0200

csiph-web