[PATCH v2 1/4] clocksource: timer-atmel-pit: enable mck

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/4] clocksource: timer-atmel-pit: enable mck
Date	2016-08-08 15:40 +0200
Message-ID	<s3SWC-1Y6-41@gated-at.bofh.it> (permalink)
References	<s3SWB-1Y6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

mck is needed to get the PIT working. Explicitly prepare_enable it instead
of assuming it is enabled.

This solves an issue where the system is freezing when the ETM/ETB drivers
are enabled.

Reported-by: Olivier Schonken <olivier.schonken@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/clocksource/timer-atmel-pit.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 1ffac0cb0cb7..db839fc99a8e 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -261,6 +261,9 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node)
 		return PTR_ERR(data->mck);
 	}
 
+	if (clk_prepare_enable(data->mck))
+		panic(pr_fmt("Unable to enable mck\n"));
+
 	/* Get the interrupts property */
 	data->irq = irq_of_parse_and_map(node, 0);
 	if (!data->irq) {
-- 
2.8.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] clocksource: timer-atmel-pit: driver fix and cleanups Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200
  [PATCH v2 2/4] clocksource: timer-atmel-pit: drop at91sam926x_pit_common_init Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200
  [PATCH v2 3/4] clocksource: timer-atmel-pit: remove uselesss WARN_ON_ONCE Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200
  [PATCH v2 4/4] clocksource: timer-atmel-pit: simplify IRQ handler Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200
  [PATCH v2 1/4] clocksource: timer-atmel-pit: enable mck Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200

csiph-web