Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457794
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 4/4] clocksource: timer-atmel-pit: simplify IRQ handler |
| Date | 2016-08-08 15:40 +0200 |
| Message-ID | <s3SWB-1Y6-21@gated-at.bofh.it> (permalink) |
| References | <s3SWB-1Y6-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Because the PIT is also a proper clocksource, the timekeeping code is
already able to handle lost ticks.
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/clocksource/timer-atmel-pit.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index af657fdce665..c5f3291328bd 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -152,15 +152,10 @@ static irqreturn_t at91sam926x_pit_interrupt(int irq, void *dev_id)
/* The PIT interrupt may be disabled, and is shared */
if (clockevent_state_periodic(&data->clkevt) &&
(pit_read(data->base, AT91_PIT_SR) & AT91_PIT_PITS)) {
- unsigned nr_ticks;
-
/* Get number of ticks performed before irq, and ack it */
- nr_ticks = PIT_PICNT(pit_read(data->base, AT91_PIT_PIVR));
- do {
- data->cnt += data->cycle;
- data->clkevt.event_handler(&data->clkevt);
- nr_ticks--;
- } while (nr_ticks);
+ data->cnt += data->cycle * PIT_PICNT(pit_read(data->base,
+ AT91_PIT_PIVR));
+ data->clkevt.event_handler(&data->clkevt);
return IRQ_HANDLED;
}
--
2.8.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/4] clocksource: timer-atmel-pit: driver fix and cleanups Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 2/4] clocksource: timer-atmel-pit: drop at91sam926x_pit_common_init Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 3/4] clocksource: timer-atmel-pit: remove uselesss WARN_ON_ONCE Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 4/4] clocksource: timer-atmel-pit: simplify IRQ handler Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 1/4] clocksource: timer-atmel-pit: enable mck Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200
csiph-web