Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457792
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 3/4] clocksource: timer-atmel-pit: remove uselesss WARN_ON_ONCE |
| Date | 2016-08-08 15:40 +0200 |
| Message-ID | <s3SWB-1Y6-11@gated-at.bofh.it> (permalink) |
| References | <s3SWB-1Y6-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
IRQ handlers are running with IRQ disabled for a while, remove wrong
comment and useless test.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/clocksource/timer-atmel-pit.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 6767768a7849..af657fdce665 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -149,12 +149,6 @@ static irqreturn_t at91sam926x_pit_interrupt(int irq, void *dev_id)
{
struct pit_data *data = dev_id;
- /*
- * irqs should be disabled here, but as the irq is shared they are only
- * guaranteed to be off if the timer irq is registered first.
- */
- WARN_ON_ONCE(!irqs_disabled());
-
/* The PIT interrupt may be disabled, and is shared */
if (clockevent_state_periodic(&data->clkevt) &&
(pit_read(data->base, AT91_PIT_SR) & AT91_PIT_PITS)) {
--
2.8.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/4] clocksource: timer-atmel-pit: driver fix and cleanups Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 2/4] clocksource: timer-atmel-pit: drop at91sam926x_pit_common_init Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 3/4] clocksource: timer-atmel-pit: remove uselesss WARN_ON_ONCE Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 4/4] clocksource: timer-atmel-pit: simplify IRQ handler Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200 [PATCH v2 1/4] clocksource: timer-atmel-pit: enable mck Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-08 15:40 +0200
csiph-web