Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()
Date	2016-08-05 16:00 +0200
Message-ID	<s2NPk-8h7-17@gated-at.bofh.it> (permalink)
References	<s27wJ-4Vz-25@gated-at.bofh.it> <s27Q5-5ht-13@gated-at.bofh.it> <s2rYt-20R-7@gated-at.bofh.it> <s2tQC-3pp-29@gated-at.bofh.it> <s2u0h-3tC-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Andreas Kemnade <andreas@kemnade.info> [160804 09:44]:
> Nothing happens here, so the previous state of the phy remains.
> It would be disabled by the generic phy layer in drivers/phy/phy-core.c
>
> > gadget driver is loaded.
> > musb_start() is called
> >     omap2430_musb_enable() is called
> > 	calls phy_power_on(),
> > 	phy->power_count goes to 0,
> > 	phy is not powered on because power_count != 1
> > -> no gadget working, no charging.
> > 
> ... if not configured by u-boot before. USB gadget might work when
> initialized earlier in the boot process (u-boot/x-loader/mlo ...)
> and phy-twl4030 cannot do anything about it besides if we change
> drivers/phy/phy-core.c

Ssounds like an issue in the phy-twl4030-usb.c. Let's try to figure
out what all we need set there for the various components there.

PM runtime for phy-twl4030-usb.c should be for the whole PHY
device including all it's components. Then the charger and
MUSB should separately increment the PM runtime count and then
enable the component specific things. And then we have the
errata to deal with when VBUS is enabled.

If there are MUSB specific PM runtime issues then let's fix
those separately.

Regards,

Tony

Thread

[PATCH v2] musb: omap2430: do not assume balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-03 18:50 +0200
  Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-08-03 19:10 +0200
    Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-04 16:40 +0200
      Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-08-04 16:50 +0200
        Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-04 17:10 +0200
        Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-04 23:00 +0200
      Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-04 18:40 +0200
        Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-04 18:50 +0200
          Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-05 16:00 +0200
            Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-05 17:40 +0200
              Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-06 22:30 +0200
                Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-09 07:40 +0200

csiph-web