Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457116

RE: [RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue

Show all headers | View raw

> 
> On Thu, Aug 4, 2016 at 12:36 PM,  <kan.liang@intel.com> wrote:
> > From: Kan Liang <kan.liang@intel.com>
> >
> > To achieve better network performance, the key step is to distribute
> > the packets to dedicated queues according to policy and system run
> > time status.
> >
> > This patch provides an interface which can return the proper dedicated
> > queue for socket/task. Then the packets of the socket/task will be
> > redirect to the dedicated queue for better network performance.
> >
> > For selecting the proper queue, currently it uses round-robin
> > algorithm to find the available object from the given policy object
> > list. The algorithm is good enough for now. But it could be improved
> > by some adaptive algorithm later.
> >
> Seriously? You want to all of this code so we revert to TX queue selection by
> round robin?
> 

I agree that the round robin is not an optimal algorithm.
For this series, we intends to provide a generic infrastructure for review.
For the algorithm parts, it's already in our TODO list. We will replace it later.

Thanks,
Kan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue kan.liang@intel.com - 2016-08-04 21:50 +0200
  Re: [RFC V2 PATCH 17/25] net/netpolicy: introduce  netpolicy_pick_queue John Fastabend <john.fastabend@gmail.com> - 2016-08-04 22:30 +0200
    Re: [RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue Daniel Borkmann <daniel@iogearbox.net> - 2016-08-05 00:40 +0200
      Re: [RFC V2 PATCH 17/25] net/netpolicy: introduce  netpolicy_pick_queue Andi Kleen <andi@firstfloor.org> - 2016-08-05 01:00 +0200
        Re: [RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue Daniel Borkmann <daniel@iogearbox.net> - 2016-08-05 02:20 +0200
          Re: [RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue Tom Herbert <tom@herbertland.com> - 2016-08-05 16:50 +0200
  Re: [RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue Tom Herbert <tom@herbertland.com> - 2016-08-05 06:00 +0200
    RE: [RFC V2 PATCH 17/25] net/netpolicy: introduce  netpolicy_pick_queue "Liang, Kan" <kan.liang@intel.com> - 2016-08-05 16:00 +0200
      Re: [RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue Tom Herbert <tom@herbertland.com> - 2016-08-05 16:40 +0200

csiph-web