Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1456719

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

From Andreas Kemnade <andreas@kemnade.info>
Newsgroups linux.kernel
Subject Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()
Date 2016-08-04 23:00 +0200
Message-ID <s2xUd-6f1-9@gated-at.bofh.it> (permalink)
References <s27wJ-4Vz-25@gated-at.bofh.it> <s27Q5-5ht-13@gated-at.bofh.it> <s2rYt-20R-7@gated-at.bofh.it> <s2s8a-24U-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 4 Aug 2016 16:49:30 +0200
"H. Nikolaus Schaller" <hns@goldelico.com> wrote:

> > Rationale:
> > 
> > The charger driver calls pm_runtime_get_sync(bci->transceiver->dev);
> > which should indirectly call twl4030_usb_set_mode to set the
> > POWER_CTRL_OTG_ENAB bit. This enables the prescaler hardware
> > for ADC8 (VBUS) channel. But this does not happen for reasons
> > outside the charger driver.
> > 
how should that work?
I only have seen the call trace from the musb/omap2430.c glue though
the phy subsystem (via phy_ops) to  twl4030_phy_power_on (which sets
the important bit).
And the phy subsystem has its own power refcounting system which
is brought into disorder by unbalanced calls from the musb system...

Regards,
Andreas

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] musb: omap2430: do not assume balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-03 18:50 +0200
  Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-08-03 19:10 +0200
    Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-04 16:40 +0200
      Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-08-04 16:50 +0200
        Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-04 17:10 +0200
        Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-04 23:00 +0200
      Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-04 18:40 +0200
        Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-04 18:50 +0200
          Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-05 16:00 +0200
            Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-05 17:40 +0200
              Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced  enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-08-06 22:30 +0200
                Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume  balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-08-09 07:40 +0200

csiph-web