Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Julia Lawall Newsgroups: linux.kernel Subject: [PATCH 08/11 v2] net/fsl: use of_property_read_bool Date: Fri, 05 Aug 2016 13:30:02 +0200 Message-ID: References:

X-Original-To: netdev@vger.kernel.org X-Ironport-Av: E=Sophos;i="5.28,473,1464645600"; d="scan'208";a="229100874" X-X-Sender: jll@hadrien User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 42 Organization: linux.* mail to news gateway X-Original-Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Fri, 5 Aug 2016 13:24:12 +0200 (CEST) X-Original-Message-ID: X-Original-References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr> <1470387411-15879-9-git-send-email-Julia.Lawall@lip6.fr> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1457036 Use of_property_read_bool to check for the existence of a property. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2,x; @@ - if (of_get_property(e1,e2,NULL)) - x = true; - else - x = false; + x = of_property_read_bool(e1,e2); // Signed-off-by: Julia Lawall --- v2: special case for propagating true and false drivers/net/ethernet/freescale/xgmac_mdio.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index 7b8fe86..e03b30c 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -271,11 +271,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev) goto err_ioremap; } - if (of_get_property(pdev->dev.of_node, - "little-endian", NULL)) - priv->is_little_endian = true; - else - priv->is_little_endian = false; + priv->is_little_endian = of_property_read_bool(pdev->dev.of_node, + "little-endian"); ret = of_mdiobus_register(bus, np); if (ret) {