Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453170 > unrolled thread

Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the  function call "dma_pool_destroy" Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-01 14:20 +0200
    Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the  function call "dma_pool_destroy" Mike Waychison <mikew@google.com> - 2016-08-01 18:40 +0200

#1453170 — Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"

On Sun, 24 Jul, at 10:27:49AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 24 Jul 2016 10:16:56 +0200
> 
> The dma_pool_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/firmware/google/gsmi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Looks fine to me. If Mike doesn't pick this up I'll take it through
the EFI tree.

[toc] | [next] | [standalone]

#1453308

On Mon, Aug 1, 2016 at 5:04 AM, Matt Fleming <matt@codeblueprint.co.uk> wrote:
>
> On Sun, 24 Jul, at 10:27:49AM, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 24 Jul 2016 10:16:56 +0200
> >
> > The dma_pool_destroy() function tests whether its argument is NULL
> > and then returns immediately. Thus the test around the call is not needed.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  drivers/firmware/google/gsmi.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Looks fine to me. If Mike doesn't pick this up I'll take it through
> the EFI tree.

Yes please do.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web