Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro
Date	2016-08-02 20:00 +0200
Message-ID	<s1M8V-7Lb-3@gated-at.bofh.it> (permalink)
References	<s1HVF-50V-81@gated-at.bofh.it> <s1LZh-7Ht-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-08-02 at 19:42 +0200, Pavel Machek wrote:
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> > 
> > -core_param(no_bL_switcher, no_bL_switcher, bool, 0644);
> > +core_param(no_bL_switcher, no_bL_switcher, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

> Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR |
> S_IRCRP | S_IROTH (*). Please don't do this.

Perhaps this conversion is best done in reverse with
most all of the S_[A-Z]{5,5} uses converted to octal.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Pavel Machek <pavel@ucw.cz> - 2016-08-02 19:50 +0200
  Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Pavel Machek <pavel@ucw.cz> - 2016-08-02 20:00 +0200
  Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Joe Perches <joe@perches.com> - 2016-08-02 20:00 +0200

csiph-web