Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401699

[PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m

Show all headers | View raw

When CONFIG_OF_MDIO is configured as module, the #define for it really
is CONFIG_OF_MDIO_MODULE, not CONFIG_OF_MDIO. So if we are compiling it
as module, the dp83867 doesn't see that OF_MDIO was selected and doesn't
read the dt rgmii parameters.

The fix is simple: Use IS_ENABLED(). It checks for both - module as well
as compiled in code.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 drivers/net/phy/dp83867.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 2afa61b..94cc278 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -99,7 +99,7 @@ static int dp83867_config_intr(struct phy_device *phydev)
 	return phy_write(phydev, MII_DP83867_MICR, micr_status);
 }
 
-#ifdef CONFIG_OF_MDIO
+#if IS_ENABLED(CONFIG_OF_MDIO)
 static int dp83867_of_init(struct phy_device *phydev)
 {
 	struct dp83867_private *dp83867 = phydev->priv;
-- 
1.8.5.6

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m Alexander Graf <agraf@suse.de> - 2016-05-16 21:00 +0200
  [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-16 21:00 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Florian Fainelli <f.fainelli@gmail.com> - 2016-05-16 21:10 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Andrew Lunn <andrew@lunn.ch> - 2016-05-16 22:20 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-16 22:30 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional David Miller <davem@davemloft.net> - 2016-05-17 20:30 +0200
      Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-17 20:40 +0200
        Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional David Miller <davem@davemloft.net> - 2016-05-17 20:50 +0200
          Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-17 22:40 +0200
            Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-17 22:50 +0200
              Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-17 22:50 +0200
  Re: [PATCH v2 1/2] phy dp83867: Fix compilation with  CONFIG_OF_MDIO=m David Miller <davem@davemloft.net> - 2016-05-17 20:30 +0200

csiph-web