Re: [PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m
Date	2016-05-17 20:30 +0200
Message-ID	<rzRUJ-82O-1@gated-at.bofh.it> (permalink)
References	<rzvUd-2fp-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Alexander Graf <agraf@suse.de>
Date: Mon, 16 May 2016 20:52:42 +0200

> When CONFIG_OF_MDIO is configured as module, the #define for it really
> is CONFIG_OF_MDIO_MODULE, not CONFIG_OF_MDIO. So if we are compiling it
> as module, the dp83867 doesn't see that OF_MDIO was selected and doesn't
> read the dt rgmii parameters.
> 
> The fix is simple: Use IS_ENABLED(). It checks for both - module as well
> as compiled in code.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m Alexander Graf <agraf@suse.de> - 2016-05-16 21:00 +0200
  [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-16 21:00 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Florian Fainelli <f.fainelli@gmail.com> - 2016-05-16 21:10 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Andrew Lunn <andrew@lunn.ch> - 2016-05-16 22:20 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-16 22:30 +0200
    Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional David Miller <davem@davemloft.net> - 2016-05-17 20:30 +0200
      Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-17 20:40 +0200
        Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional David Miller <davem@davemloft.net> - 2016-05-17 20:50 +0200
          Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-17 22:40 +0200
            Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-17 22:50 +0200
              Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-17 22:50 +0200
  Re: [PATCH v2 1/2] phy dp83867: Fix compilation with  CONFIG_OF_MDIO=m David Miller <davem@davemloft.net> - 2016-05-17 20:30 +0200

csiph-web