Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1402525
| From | Dan Murphy <dmurphy@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional |
| Date | 2016-05-17 20:40 +0200 |
| Message-ID | <rzS4q-875-9@gated-at.bofh.it> (permalink) |
| References | <rzvUd-2fp-3@gated-at.bofh.it> <rzvUe-2fp-19@gated-at.bofh.it> <rzRUK-82O-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
David On 05/17/2016 01:22 PM, David Miller wrote: > From: Alexander Graf <agraf@suse.de> > Date: Mon, 16 May 2016 20:52:43 +0200 > >> If you compile without OF_MDIO support in an RGMII configuration, we fail >> to configure the dp83867 phy today by writing garbage into its configuration >> registers. >> >> On the other hand if you do compile with OF_MDIO and the phy gets loaded via >> device tree, you have to have the properties set in the device tree, otherwise >> we fail to load the driver and don't even attach the generic phy driver to >> the interface anymore. >> >> To make things slightly more consistent, make the rgmii configuration properties >> optional and allow a user to omit them in their device tree. >> >> Signed-off-by: Alexander Graf <agraf@suse.de> > Applied. This patch should not have been applied. I did not believe the implementation was proper for that driver. It seems my objection to the code was not seen. Nor was Andrew's point about the DT bindings document https://patchwork.kernel.org/patch/9105371/ Dan -- ------------------ Dan Murphy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m Alexander Graf <agraf@suse.de> - 2016-05-16 21:00 +0200
[PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-16 21:00 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Florian Fainelli <f.fainelli@gmail.com> - 2016-05-16 21:10 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Andrew Lunn <andrew@lunn.ch> - 2016-05-16 22:20 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-16 22:30 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional David Miller <davem@davemloft.net> - 2016-05-17 20:30 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-17 20:40 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional David Miller <davem@davemloft.net> - 2016-05-17 20:50 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-17 22:40 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Dan Murphy <dmurphy@ti.com> - 2016-05-17 22:50 +0200
Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf <agraf@suse.de> - 2016-05-17 22:50 +0200
Re: [PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m David Miller <davem@davemloft.net> - 2016-05-17 20:30 +0200
csiph-web