Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1402191
| Path | csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Miklos Szeredi <mszeredi@redhat.com> |
| Newsgroups | linux.kernel |
| Subject | Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker |
| Date | Tue, 17 May 2016 10:20:01 +0200 |
| Message-ID | <rzIop-252-11@gated-at.bofh.it> (permalink) |
| References | <rzkvM-3ws-9@gated-at.bofh.it> <rzqrv-7tO-3@gated-at.bofh.it> <rzGFX-XB-3@gated-at.bofh.it> |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=cCZox0Qe5Vf26MYn/udyC6qvoCvIj/u1mMlB7hcZAWM=; b=V3nQxVO8iU6um1J1Yt53z+eWXKa2QTai3MYtQocLNsm4r9gyp6xuzYEHUltzEu8RxH CrJug42gLzy7eV3CgUDJ6ftL4pz9hDifHCdngejrCSsQ1vvEQZF/KiVVzcXhs4xeCWDW ZZBaXC0aBPlcfkQE2gfq4suBsMwiwYE7Dn5n6Uwf/NmTFIYHokFuBqJ1/VT53DtHiTSA dTMkyGax/DdUADsEFH6gxrDuAS9WiUpq0n+CmKDZHP8h7CaM1aP2WApX2z9HWd9CR4pp 7+1DUl+GgFTnTomRjCllMJBNSKdnjbUWw7LLXG/ARYk2HUTU4hLpIg8XGEaIV6/QWhZ8 tDcg== |
| X-Gm-Message-State | AOPr4FUd61ZEyRXEFT1ZsRKgRpKJM4sxIc4VTEsyCAN4b5qxq0itUpDoBc98nY3M7a3U71EIX4X7IEpQp43uaCTQ |
| MIME-Version | 1.0 |
| X-Received | by 10.112.201.105 with SMTP id jz9mr13297181lbc.6.1463472921213; Tue, 17 May 2016 01:15:21 -0700 (PDT) |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 19 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Vivek Goyal <vgoyal@redhat.com>, Daniel Axtens <dja@axtens.net>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, mpe@ellerman.id.au, dchinner@redhat.com |
| X-Original-Date | Tue, 17 May 2016 10:15:21 +0200 |
| X-Original-Message-ID | <CAOssrKejFhkVssL19uXQnfuEMfP8CXNPMHNGq0_3yazPOk+Xpg@mail.gmail.com> |
| X-Original-References | <87d1ombix6.fsf@gamma.ozlabs.ibm.com> <20160516130727.GA26411@redhat.com> <20160517062829.GG14480@ZenIV.linux.org.uk> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1402191 |
Show key headers only | View raw
On Tue, May 17, 2016 at 8:28 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Mon, May 16, 2016 at 09:07:27AM -0400, Vivek Goyal wrote:
>> So it became clear that we need a check at mount time to make sure
>> d_type is supported otherwise error out. This will require users to
>> do mkfs.xfs with ftype=1 to make progress.
>>
>> I think new defaults for mkfs.xfs are such that ftype=1 is set. I am
>> not sure which version that change was made in.
>
> Dumb question - can we end up with empty workdir at that point? Because
> if we do, the check would appear to return a false negative, no matter
> what fs supports...
ovl_workdir_create() creates a subdirectory of workdir ("work") so
workdir itself won't be empty after that. If somebody else messes
with workdir, then we are screwed anyway.
Thanks,
Miklos
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-16 08:50 +0200
Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-16 15:10 +0200
Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-17 08:30 +0200
Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Miklos Szeredi <mszeredi@redhat.com> - 2016-05-17 10:20 +0200
Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-17 14:20 +0200
Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Miklos Szeredi <miklos@szeredi.hu> - 2016-05-17 16:30 +0200
Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 05:40 +0200
Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 00:40 +0200
csiph-web