Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1400727
| Path | csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Wolfram Sang <wsa@the-dreams.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling |
| Date | Fri, 13 May 2016 14:00:01 +0200 |
| Message-ID | <ryjV7-2yY-13@gated-at.bofh.it> (permalink) |
| References | <rvMgW-466-13@gated-at.bofh.it> <rvMgW-466-11@gated-at.bofh.it> <ryjLs-2sD-15@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45wMVEkw4XUbiYON" |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 47 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | devicetree@vger.kernel.org, architt@codeaurora.org, linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org, galak@codeaurora.org, linux-kernel@vger.kernel.org, andy.gross@linaro.org, linux-i2c@vger.kernel.org, iivanov@mm-sol.com, agross@codeaurora.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nkaje@codeaurora.org |
| X-Original-Date | Fri, 13 May 2016 13:50:21 +0200 |
| X-Original-Message-ID | <20160513115021.GK1778@katana> |
| X-Original-References | <1462534274-28925-1-git-send-email-sricharan@codeaurora.org> <1462534274-28925-3-git-send-email-sricharan@codeaurora.org> <20160513114823.GJ1778@katana> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1400727 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
On Fri, May 13, 2016 at 01:48:23PM +0200, Wolfram Sang wrote: > On Fri, May 06, 2016 at 05:01:14PM +0530, Sricharan R wrote: > > Among the bus errors reported from the QUP_MASTER_STATUS register > > only NACK is considered and transfer gets suspended, while > > other errors are ignored. Correct this and suspend the transfer > > for other errors as well. This avoids unnessecary 'timeouts' which > > happens when waiting for events that would never happen when there > > is already an error condition on the bus. > > > > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > > Reviewed-by: Andy Gross <andy.gross@linaro.org> > > Please check Documentation/i2c/fault-codes for proper fault codes. And while we are here: NACK is not an error but a valid response. Can you remove the dev_err related to that? Otherwise tools like i2cdetect will probably flood your log.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Wolfram Sang <wsa@the-dreams.de> - 2016-05-13 13:50 +0200
Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Wolfram Sang <wsa@the-dreams.de> - 2016-05-13 14:00 +0200
RE: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling "Sricharan" <sricharan@codeaurora.org> - 2016-05-16 08:00 +0200
csiph-web