Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1400727
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling |
| Date | 2016-05-13 14:00 +0200 |
| Message-ID | <ryjV7-2yY-13@gated-at.bofh.it> (permalink) |
| References | <rvMgW-466-13@gated-at.bofh.it> <rvMgW-466-11@gated-at.bofh.it> <ryjLs-2sD-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Fri, May 13, 2016 at 01:48:23PM +0200, Wolfram Sang wrote: > On Fri, May 06, 2016 at 05:01:14PM +0530, Sricharan R wrote: > > Among the bus errors reported from the QUP_MASTER_STATUS register > > only NACK is considered and transfer gets suspended, while > > other errors are ignored. Correct this and suspend the transfer > > for other errors as well. This avoids unnessecary 'timeouts' which > > happens when waiting for events that would never happen when there > > is already an error condition on the bus. > > > > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > > Reviewed-by: Andy Gross <andy.gross@linaro.org> > > Please check Documentation/i2c/fault-codes for proper fault codes. And while we are here: NACK is not an error but a valid response. Can you remove the dev_err related to that? Otherwise tools like i2cdetect will probably flood your log.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Wolfram Sang <wsa@the-dreams.de> - 2016-05-13 13:50 +0200
Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Wolfram Sang <wsa@the-dreams.de> - 2016-05-13 14:00 +0200
RE: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling "Sricharan" <sricharan@codeaurora.org> - 2016-05-16 08:00 +0200
csiph-web