RE: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling

From	"Sricharan" <sricharan@codeaurora.org>
Newsgroups	linux.kernel
Subject	RE: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling
Date	2016-05-16 08:00 +0200
Message-ID	<rzjJn-2Xk-1@gated-at.bofh.it> (permalink)
References	<rvMgW-466-13@gated-at.bofh.it> <rvMgW-466-11@gated-at.bofh.it> <ryjLs-2sD-15@gated-at.bofh.it> <ryjV7-2yY-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,
> > > Among the bus errors reported from the QUP_MASTER_STATUS register
> > > only NACK is considered and transfer gets suspended, while other
> > > errors are ignored. Correct this and suspend the transfer for other
> > > errors as well. This avoids unnessecary 'timeouts' which happens
> > > when waiting for events that would never happen when there is
> > > already an error condition on the bus.
> > >
> > > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> > > Reviewed-by: Andy Gross <andy.gross@linaro.org>
> >
> > Please check Documentation/i2c/fault-codes for proper fault codes.
> 
    Ok, Thanks for pointing this out. So, for NACK I think it is more
appropriate to
    return -ENXIO and -EIO for other errors. Will correct this.

> And while we are here: NACK is not an error but a valid response. Can you
> remove the dev_err related to that? Otherwise tools like i2cdetect will
> probably flood your log.
  Ok, will correct this.

Regards,
 Sricharan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Wolfram Sang <wsa@the-dreams.de> - 2016-05-13 13:50 +0200
  Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Wolfram Sang <wsa@the-dreams.de> - 2016-05-13 14:00 +0200
    RE: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling "Sricharan" <sricharan@codeaurora.org> - 2016-05-16 08:00 +0200

csiph-web