Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400492

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH RFT 1/2] phylib: add device reset GPIO support
Date 2016-05-13 06:10 +0200
Message-ID <rycAh-3F4-3@gated-at.bofh.it> (permalink)
References <rlN4B-2Mf-3@gated-at.bofh.it> <rt2rV-3gl-23@gated-at.bofh.it> <ry3Qm-2Xu-7@gated-at.bofh.it> <ry6uR-63w-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> >>+	gpiod = fwnode_get_named_gpiod(&child->fwnode, "reset-gpios");
> >>+	/* Deassert the reset signal */
> >>+	if (!IS_ERR(gpiod))
> >>+		gpiod_direction_output(gpiod, 0);
> >
> >This is wrong I think. You must only ignore -ENODEV, all other error
> 
>    At least -ENOSYS should also be ignored (it's returned when
> gpiolib is not configured), right? When does -ENODEV gets returned
> (it's not easy to follow)?
> 
> >codes should be passed to the caller.
> 
>    The caller doesn't care anyway...

It should do. What if fwnode_get_named_gpiod() returns -EPROBE_DEFER
because the GPIO driver has not been loaded yet?

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-29 00:20 +0200
  Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Rob Herring <robh@kernel.org> - 2016-05-03 19:10 +0200
  Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Florian Fainelli <f.fainelli@gmail.com> - 2016-05-10 20:40 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-10 21:20 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Florian Fainelli <f.fainelli@gmail.com> - 2016-05-10 21:20 +0200
  Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-05-12 20:50 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-12 23:40 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-13 06:10 +0200
        Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 23:20 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-05-13 09:10 +0200
        Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 23:50 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 21:20 +0200
        Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-16 04:10 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Roger Quadros <rogerq@ti.com> - 2016-05-13 11:10 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 21:40 +0200
        Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-13 22:50 +0200
          Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 23:00 +0200
            Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-14 01:50 +0200
              Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-14 21:40 +0200
                Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-14 22:00 +0200
                Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-16 04:10 +0200
                Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-19 15:50 +0200
                Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-16 04:10 +0200
        Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Roger Quadros <rogerq@ti.com> - 2016-05-16 11:00 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Linus Walleij <linus.walleij@linaro.org> - 2016-05-26 11:10 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-05-26 21:10 +0200
        Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Linus Walleij <linus.walleij@linaro.org> - 2016-05-30 17:00 +0200

csiph-web