Re: [PATCH 1/2] mmotm: mm-oom-rework-oom-detection-fix

From	"Hillf Danton" <hillf.zj@alibaba-inc.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mmotm: mm-oom-rework-oom-detection-fix
Date	2016-05-13 06:10 +0200
Message-ID	<rycAh-3F4-1@gated-at.bofh.it> (permalink)
References	<rxWOR-4u5-3@gated-at.bofh.it> <rxWOS-4u5-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Michal Hocko <mhocko@suse.com>
> 
> watermark check should use classzone_idx rather than high_zoneidx
> to check reserves against the correct (preferred) zone.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>

>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0d9008042efa..620ec002aea2 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3496,7 +3496,7 @@ should_reclaim_retry(gfp_t gfp_mask, unsigned order,
>  		 * available?
>  		 */
>  		if (__zone_watermark_ok(zone, order, min_wmark_pages(zone),
> -				ac->high_zoneidx, alloc_flags, available)) {
> +				ac_classzone_idx(ac), alloc_flags, available)) {
>  			/*
>  			 * If we didn't make any progress and have a lot of
>  			 * dirty + writeback pages then we should wait for
> --
> 2.8.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] oom detection fixups Michal Hocko <mhocko@kernel.org> - 2016-05-12 13:20 +0200
  [PATCH 2/2] mm, oom: protect !costly allocations some more for !CONFIG_COMPACTION Michal Hocko <mhocko@kernel.org> - 2016-05-12 13:20 +0200
    Re: [PATCH 2/2] mm, oom: protect !costly allocations some more for !CONFIG_COMPACTION "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-05-13 06:20 +0200
  [PATCH 1/2] mmotm: mm-oom-rework-oom-detection-fix Michal Hocko <mhocko@kernel.org> - 2016-05-12 13:20 +0200
    Re: [PATCH 1/2] mmotm: mm-oom-rework-oom-detection-fix "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-05-13 06:10 +0200

csiph-web