Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401141

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

Show all headers | View raw

On Sat, May 14, 2016 at 10:36:38PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 05/14/2016 02:44 AM, Andrew Lunn wrote:
> 
> >>>>>Another issue is that on some boards we have one reset line tied to
> >>>>>multiple PHYs.How do we prevent multiple resets being taking place when each of
> >>>>>the PHYs are registered?
> >>>>
> >>>>  My patch just doesn't address this case -- it's about the
> >>>>individual resets only.
> >>>
> >>>This actually needs to be addresses a layer above. What you have is a
> >>>bus reset, not a device reset.
> >>
> >>   No.
> >>   There's simply no such thing as a bus reset for the xMII/MDIO
> >>busses, there's simply no reset signaling on them. Every device has
> >>its own reset signal and its own timing requirements.
> >
> >Except in the case above, where two phys are sharing the same reset
> >signal. So although it is not part of the mdio standard to have a bus
> >reset, this is in effect what the gpio line is doing, resetting all
> >devices on the bus. If you don't model that as a bus reset, how do you
> >model it?
> 
>    I'm not suggesting that the shared reset should be handled by my
> patch. Contrariwise, I suggested to use the mii_bus::reset() method

I think we miss understood each other somewhere.

Your code is great for one gpio reset line for one phy.

I think there could be similar code one layer above to handle one gpio
line for multiple phys.

     Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-05-12 20:50 +0200
  Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-12 23:40 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-13 06:10 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 23:20 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-05-13 09:10 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 23:50 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 21:20 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-16 04:10 +0200
  Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Roger Quadros <rogerq@ti.com> - 2016-05-13 11:10 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 21:40 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-13 22:50 +0200
        Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-13 23:00 +0200
          Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-14 01:50 +0200
            Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-14 21:40 +0200
              Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-14 22:00 +0200
                Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Andrew Lunn <andrew@lunn.ch> - 2016-05-16 04:10 +0200
                Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-19 15:50 +0200
                Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-05-16 04:10 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Roger Quadros <rogerq@ti.com> - 2016-05-16 11:00 +0200
  Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Linus Walleij <linus.walleij@linaro.org> - 2016-05-26 11:10 +0200
    Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-05-26 21:10 +0200
      Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Linus Walleij <linus.walleij@linaro.org> - 2016-05-30 17:00 +0200

csiph-web