[PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str

From	Julien Grall <julien.grall@arm.com>
Newsgroups	linux.kernel
Subject	[PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str
Date	2016-05-10 16:50 +0200
Message-ID	<rxh90-4bJ-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The loop that browses the array compat_hwcap_str will stop when a NULL
is encountered, however NULL is missing at the end of array. This will
result to overrun until one NULL is found somewhere in the memory.

Fixes: 44b82b7700d0 "arm64: Fix up /proc/cpuinfo"
Signed-off-by: Julien Grall <julien.grall@arm.com>
Cc: stable@vger.kernel.org

---

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Suzuki K. Poulose <suzuki.poulose@arm.com>
---
 arch/arm64/kernel/cpuinfo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
index 84c8684..f0c3fb7 100644
--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c
@@ -87,7 +87,8 @@ static const char *const compat_hwcap_str[] = {
 	"idivt",
 	"vfpd32",
 	"lpae",
-	"evtstrm"
+	"evtstrm",
+	NULL
 };
 
 static const char *const compat_hwcap2_str[] = {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str Julien Grall <julien.grall@arm.com> - 2016-05-10 16:50 +0200
  Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in  compat_hwcap_str Mark Rutland <mark.rutland@arm.com> - 2016-05-10 17:00 +0200
    Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in  compat_hwcap_str Julien Grall <julien.grall@arm.com> - 2016-05-11 11:40 +0200
      Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in  compat_hwcap_str Will Deacon <will.deacon@arm.com> - 2016-05-11 11:50 +0200

csiph-web