Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1398164

[PATCH RFC] ctype: update comments

Show all headers | View raw

We have isspace() which may be used incorrectly as one might expect that
it has the same meaning as POSIX isspace(). Also, kernel has outdated
comment about of what is space and hard space exactely.

Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
---
 include/linux/ctype.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/include/linux/ctype.h b/include/linux/ctype.h
index 653589e..5c03748 100644
--- a/include/linux/ctype.h
+++ b/include/linux/ctype.h
@@ -11,9 +11,20 @@
 #define _D	0x04	/* digit */
 #define _C	0x08	/* cntrl */
 #define _P	0x10	/* punct */
-#define _S	0x20	/* white space (space/lf/tab) */
+#define _S	0x20	/* space
+			   0x09 - Horizontal Tab (HT)
+			   0x0A - Line Feed (LF)
+			   0x0B - Vertical Tab (VT)
+			   0x0C - Form Feed (FF)
+			   0x0D - Carriage Return (CR)
+			   0x20 - Space (SP)
+			   0xA0 - Non-Breakable Space (NBSP)
+			*/
 #define _X	0x40	/* hex digit */
-#define _SP	0x80	/* hard space (0x20) */
+#define _SP	0x80	/* hard space
+			   0x20 - Space (SP)
+			   0xA0 - Non-Breakable Space (NBSP)
+			 */
 
 extern const unsigned char _ctype[];
 
-- 
2.8.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH RFC] ctype: update comments "Ilya V. Matveychikov" <matvejchikov@gmail.com> - 2016-05-10 16:50 +0200

csiph-web