Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str
Date	2016-05-11 11:50 +0200
Message-ID	<rxyWf-5Bh-41@gated-at.bofh.it> (permalink)
References	<rxh90-4bJ-7@gated-at.bofh.it> <rxhiG-4hZ-15@gated-at.bofh.it> <rxyMz-5vM-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 11, 2016 at 10:38:36AM +0100, Julien Grall wrote:
> Hi Mark,
> 
> On 10/05/2016 15:54, Mark Rutland wrote:
> >On Tue, May 10, 2016 at 03:40:31PM +0100, Julien Grall wrote:
> >>The loop that browses the array compat_hwcap_str will stop when a NULL
> >>is encountered, however NULL is missing at the end of array. This will
> >>result to overrun until one NULL is found somewhere in the memory.
> >
> >Probably worth adding something like:
> >
> >Note for backporting: commit 12d11817eaafa414 ("arm64: Move
> >/proc/cpuinfo handling code") moved this code. Prior to that commit, the
> >same change should be made in arch/arm64/kernel/setup.c.
> 
> I can resend the patch with this changes.

No need, I've already applied it locally with Mark's suggestions.

Will

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str Julien Grall <julien.grall@arm.com> - 2016-05-10 16:50 +0200
  Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in  compat_hwcap_str Mark Rutland <mark.rutland@arm.com> - 2016-05-10 17:00 +0200
    Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in  compat_hwcap_str Julien Grall <julien.grall@arm.com> - 2016-05-11 11:40 +0200
      Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in  compat_hwcap_str Will Deacon <will.deacon@arm.com> - 2016-05-11 11:50 +0200

csiph-web