Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface
Date	2016-05-12 10:40 +0200
Message-ID	<rxUk2-1QS-11@gated-at.bofh.it> (permalink)
References	<rxjub-6Xg-17@gated-at.bofh.it> <rxjub-6Xg-19@gated-at.bofh.it> <rxvOF-2AY-3@gated-at.bofh.it> <rxEfg-2vs-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Kees Cook <keescook@chromium.org> wrote:

> On Tue, May 10, 2016 at 11:24 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Kees Cook <keescook@chromium.org> wrote:
> >
> >> +/*
> >> + * Mapping information structure passed to kernel_ident_mapping_init().
> >> + * Due to relocation, pointers must be assigned at run time not build time.
> >> + */
> >> +static struct x86_mapping_info mapping_info = {
> >> +     .pmd_flag       = __PAGE_KERNEL_LARGE_EXEC,
> >> +};
> >
> >> +void initialize_identity_maps(void)
> >>  {
> >> +     /* Init mapping_info with run-time function/buffer pointers. */
> >> +     mapping_info.alloc_pgt_page = alloc_pgt_page;
> >> +     mapping_info.context = &pgt_data;
> >
> > Could you please outline the precise failure mode? What gets executed when, which
> > pointer gets relocated and which not, and exactly when does it pose a problem,
> > etc.
> 
> It's the issue described at the top of misc.c:
> 
> /*
>  * WARNING!!
>  * This code is compiled with -fPIC and it is relocated dynamically at
>  * run time, but no relocation processing is performed. This means that
>  * it is not safe to place pointers in static structures.
>  */

Btw., is there any way to detect such invalid pointers during build-time somehow? 
This is not the first such bug and I suspect it won't be the last one either.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v8 1/4] x86/KASLR: Clarify identity map interface Kees Cook <keescook@chromium.org> - 2016-05-10 19:20 +0200
  Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Borislav Petkov <bp@suse.de> - 2016-05-10 19:50 +0200
  Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Ingo Molnar <mingo@kernel.org> - 2016-05-11 08:30 +0200
    Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Kees Cook <keescook@chromium.org> - 2016-05-11 17:30 +0200
      Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:40 +0200
      Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:40 +0200

csiph-web