Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399754

Re: [PATCH v4 07/18] nbd: fix checkpatch split string warning.

From Markus Pargmann <mpa@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v4 07/18] nbd: fix checkpatch split string warning.
Date 2016-05-12 10:40 +0200
Message-ID <rxUk2-1QS-13@gated-at.bofh.it> (permalink)
References <rxxx8-4bl-5@gated-at.bofh.it> <rxxx9-4bl-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wednesday 11 May 2016 11:18:35 Pranay Kr. Srivastava wrote:
> Signed-off-by: Pranay Kr. Srivastava <pranjas@gmail.com>
> ---
>  drivers/block/nbd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index 6a4dc3a..7a5b8ef 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -587,8 +587,7 @@ static int nbd_thread_send(void *data)
>  				nbd_send_req(nbd, &sreq);
>  				mutex_unlock(&nbd->tx_lock);
>  				dev_err(disk_to_dev(nbd->disk),
> -					"Device Timeout occured.Shutting down"
> -					" socket.");
> +				"Device Timeout occured.Shutting down socket.");

Please keep the indentation to the opening bracket here. Shouldn't this
create a checkpatch warning as well?

Regards,

Markus

>  			}
>  			mutex_unlock(&nbd->sock_lock);
>  			sock_shutdown(nbd);
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/18] nbd: fixes for might_sleep warning, checkpatch warning and device wait. "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:20 +0200
  [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:20 +0200
    Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Markus Pargmann <mpa@pengutronix.de> - 2016-05-12 11:50 +0200
    Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Markus Pargmann <mpa@pengutronix.de> - 2016-05-19 08:30 +0200
      Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Pranay Srivastava <pranjas@gmail.com> - 2016-05-19 22:40 +0200
        Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Markus Pargmann <mpa@pengutronix.de> - 2016-05-20 10:30 +0200
          Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Pranay Srivastava <pranjas@gmail.com> - 2016-05-23 12:40 +0200
            Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Pranay Srivastava <pranjas@gmail.com> - 2016-05-25 19:20 +0200
  [PATCH v4 07/18] nbd: fix checkpatch split string warning. "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:20 +0200
    Re: [PATCH v4 07/18] nbd: fix checkpatch split string warning. Markus Pargmann <mpa@pengutronix.de> - 2016-05-12 10:40 +0200
  [PATCH v4 03/18] nbd: fix checkpatch warning use linux/uaccess.h "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 09/18] nbd: fix checkpatch trailing whitespace warning. "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 16/18] nbd: fix checkpatch no new line after decleration warning "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 15/18] nbd: fix checkpatch printk warning to pr_info "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 10/18] nbd: fix checkpatch trailing whitespace warning. "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 18/18] make nbd device wait for its users in case of timeout "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
    Re: [PATCH v4 18/18] make nbd device wait for its users in case of timeout Markus Pargmann <mpa@pengutronix.de> - 2016-05-12 11:20 +0200
      Re: [PATCH v4 18/18] make nbd device wait for its users in case of timeout Pranay Srivastava <pranjas@gmail.com> - 2016-05-12 17:20 +0200
        Re: [PATCH v4 18/18] make nbd device wait for its users in case of  timeout Markus Pargmann <mpa@pengutronix.de> - 2016-05-19 08:40 +0200
  [PATCH v4 11/18] nbd : fix checkpatch structure declaration braces on next line warning. "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 06/18] nbd: fix checkpatch warning no newline after decleration. "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 17/18] nbd: fix checkpatch printk warning to pr_info "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 14/18] nbd: fix checkpatch no extra line after decleration warning "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 13/18] nbd : fix checkpatch printk warning "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200
  [PATCH v4 12/18] nbd : fix checkpatch trailing whitespace warning "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2016-05-11 10:30 +0200

csiph-web