Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface
Date	2016-05-10 19:50 +0200
Message-ID	<rxjXd-7jo-27@gated-at.bofh.it> (permalink)
References	<rxjub-6Xg-17@gated-at.bofh.it> <rxjub-6Xg-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 10, 2016 at 10:19:12AM -0700, Kees Cook wrote:
> This extracts the call to prepare_level4() into a top-level function
> that the user of the pagetable.c interface must call to initialize
> the new page tables. For clarity and to match the "finalize" function,
> it has been renamed to initialize_identity_maps(). This function also
> gains the initialization of mapping_info so we don't have to do it each
> time in add_identity_map().
> 
> Additionally add copyright notice to the top, to make it clear that the
> bulk of the pagetable.c code was written by Yinghai, and that I just
> added bugs later. :)
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  arch/x86/boot/compressed/kaslr.c     |  3 +++
>  arch/x86/boot/compressed/misc.h      |  3 +++
>  arch/x86/boot/compressed/pagetable.c | 26 ++++++++++++++++----------
>  3 files changed, 22 insertions(+), 10 deletions(-)

Exactly!

Acked-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Thread

[PATCH v8 1/4] x86/KASLR: Clarify identity map interface Kees Cook <keescook@chromium.org> - 2016-05-10 19:20 +0200
  Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Borislav Petkov <bp@suse.de> - 2016-05-10 19:50 +0200
  Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Ingo Molnar <mingo@kernel.org> - 2016-05-11 08:30 +0200
    Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Kees Cook <keescook@chromium.org> - 2016-05-11 17:30 +0200
      Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:40 +0200
      Re: [PATCH v8 1/4] x86/KASLR: Clarify identity map interface Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:40 +0200

csiph-web