Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP()
Date	2016-05-03 23:20 +0200
Message-ID	<ruPTA-7jM-19@gated-at.bofh.it> (permalink)
References	<ruDfH-3LT-3@gated-at.bofh.it> <ruDpo-3Rg-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 03, 2016 at 10:53:05AM +0300, Felipe Balbi wrote:
> 
> Hi,
> 
> Dan Carpenter <dan.carpenter@oracle.com> writes:
> > In the original DWC3_DCFG_NUMP() was always zero.  It looks like the
> > intent was to shift first and then do the mask.
> >
> > Fixes: 2a58f9c12bb3 ('usb: dwc3: gadget: disable automatic calculation of ACK TP NUMP')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Thanks for this fix, I completely missed it :-) Greg, if you want to
> take this as a patch, that's fine by me. Otherwise I can queue it for
> -rc1. In any case, S-o-B below:
> 
> Signed-off-by: Felipe Balbi <balbi@kernel.org>

I'll take it, thanks.

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] usb: dwc3: gadget: fix mask and shift order in  DWC3_DCFG_NUMP() Dan Carpenter <dan.carpenter@oracle.com> - 2016-05-03 09:50 +0200
  Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP() Felipe Balbi <balbi@kernel.org> - 2016-05-03 10:00 +0200
    Re: [patch] usb: dwc3: gadget: fix mask and shift order in  DWC3_DCFG_NUMP() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-03 23:20 +0200

csiph-web