Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1393825

Re: [PATCH v7 1/6] Shared library support

Show all headers | View raw

On Mon, 2 May 2016 14:03:00 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

Hi,

> > diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
> > index 55c96cb..e4e88ab 100644
> > --- a/scripts/Makefile.clean
> > +++ b/scripts/Makefile.clean
> > @@ -38,7 +38,8 @@ subdir-ymn    := $(addprefix $(obj)/,$(subdir-ymn))
> >  __clean-files  := $(extra-y) $(extra-m) $(extra-)       \
> >                    $(always) $(targets) $(clean-files)   \
> >                    $(host-progs)                         \
> > -                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-)
> > +                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-) \
> > +                  $(hostlibs-y) $(hostlibs-m) $(hostlibs-)
> 
> $(hostcxxlibs-y)$(hostcxxlibs-m) is missing here.
> 
> 
> BTW, are you planning to support hostlibs without .so extention in the future?
> 
> 
> You are changing the top Makefile to clean with "*.so" pattern rule.
> 
> Do you need to change both the top Makefile and Makefile.clean
> for belt-and-braces cleaning?

It doesn't delete the *.so files without the hunk from the top Makefile. 
The mrproper and distclean targets remove them with this patch:
https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/f23b7eb247ccc9f1007e53313af343980dd52591
But I think this isn't the best solution much like doing it from the top Makefile.

-- 
Emese

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 1/6] Shared library support Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-02 07:10 +0200
  Re: [PATCH v7 1/6] Shared library support Emese Revfy <re.emese@gmail.com> - 2016-05-02 19:50 +0200
    Re: [PATCH v7 1/6] Shared library support Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-03 04:10 +0200
      Re: [PATCH v7 1/6] Shared library support Emese Revfy <re.emese@gmail.com> - 2016-05-03 23:30 +0200
        Re: [PATCH v7 1/6] Shared library support Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-04 06:10 +0200
          Re: [PATCH v7 1/6] Shared library support Emese Revfy <re.emese@gmail.com> - 2016-05-05 20:40 +0200
    Re: [PATCH v7 1/6] Shared library support Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-03 04:10 +0200
  Re: [PATCH v7 1/6] Shared library support Emese Revfy <re.emese@gmail.com> - 2016-05-03 23:20 +0200
    Re: [PATCH v7 1/6] Shared library support Emese Revfy <re.emese@gmail.com> - 2016-05-05 20:40 +0200

csiph-web