Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393116
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP() |
| Date | 2016-05-03 09:50 +0200 |
| Message-ID | <ruDfH-3LT-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
In the original DWC3_DCFG_NUMP() was always zero. It looks like the
intent was to shift first and then do the mask.
Fixes: 2a58f9c12bb3 ('usb: dwc3: gadget: disable automatic calculation of ACK TP NUMP')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 186a886..7ddf944 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -277,7 +277,7 @@
#define DWC3_DCFG_FULLSPEED1 (3 << 0)
#define DWC3_DCFG_NUMP_SHIFT 17
-#define DWC3_DCFG_NUMP(n) (((n) & 0x1f) >> DWC3_DCFG_NUMP_SHIFT)
+#define DWC3_DCFG_NUMP(n) (((n) >> DWC3_DCFG_NUMP_SHIFT) & 0x1f)
#define DWC3_DCFG_NUMP_MASK (0x1f << DWC3_DCFG_NUMP_SHIFT)
#define DWC3_DCFG_LPM_CAP (1 << 22)
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP() Dan Carpenter <dan.carpenter@oracle.com> - 2016-05-03 09:50 +0200
Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP() Felipe Balbi <balbi@kernel.org> - 2016-05-03 10:00 +0200
Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-03 23:20 +0200
csiph-web