Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1386887
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] tpm: use devm_add_action_or_reset |
| Date | Mon, 25 Apr 2016 23:00:03 +0200 |
| Message-ID | <rrVLR-3EY-31@gated-at.bofh.it> (permalink) |
| References | <rrVCa-3B8-25@gated-at.bofh.it> |
| X-Original-To | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
| Dkim-Signature | v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=q6IT8328OG/7eX8LIWnDaqEG8BIpwFBpLOLapnG2gD4=; b=bLDT2nh3a/MfHA1jsKaFZdBACybo1ZihohpDwbwLN4UgQfhhKtSqZtn6f3iNsCh1wO1csJ9M2iImtGwtYU3KXK363lf/Px18c4B6KPlt8cWX9Mk0P1PqbTdfdCJOL1YhEMbf0IQsYBwKcILyyzwQyh3n8hCo4gXQSJ317K5LG3Q=; |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| X-Broken-Reverse-Dns | no host name found for IP address 10.0.0.160 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 8 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net |
| X-Original-Date | Mon, 25 Apr 2016 14:57:18 -0600 |
| X-Original-Message-ID | <20160425205718.GD15367@obsidianresearch.com> |
| X-Original-References | <1461617198-32351-1-git-send-email-sudipm.mukherjee@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1386887 |
Show key headers only | View raw
On Mon, Apr 25, 2016 at 09:46:38PM +0100, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup function > in the error path. Lets use the helper function devm_add_action_or_reset() > and return directly as we know the cleanup has been done by the helper. Seems reasonable to me. Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] tpm: use devm_add_action_or_reset Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-25 22:50 +0200 Re: [PATCH] tpm: use devm_add_action_or_reset Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-04-25 23:00 +0200 Re: [PATCH] tpm: use devm_add_action_or_reset Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-26 10:40 +0200
csiph-web