Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1386887

Re: [PATCH] tpm: use devm_add_action_or_reset

From Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups linux.kernel
Subject Re: [PATCH] tpm: use devm_add_action_or_reset
Date 2016-04-25 23:00 +0200
Message-ID <rrVLR-3EY-31@gated-at.bofh.it> (permalink)
References <rrVCa-3B8-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Apr 25, 2016 at 09:46:38PM +0100, Sudip Mukherjee wrote:
> If devm_add_action() fails we are explicitly calling the cleanup function
> in the error path. Lets use the helper function devm_add_action_or_reset()
> and return directly as we know the cleanup has been done by the helper.

Seems reasonable to me.

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] tpm: use devm_add_action_or_reset Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-25 22:50 +0200
  Re: [PATCH] tpm: use devm_add_action_or_reset Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-04-25 23:00 +0200
  Re: [PATCH] tpm: use devm_add_action_or_reset Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-26 10:40 +0200

csiph-web