Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386780

Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg

Show all headers | View raw

On Mon, Apr 25, 2016 at 12:06 PM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> Again, please default enable and use an easier name to toggle this.
> Userspace flooding this with junk is really insane.

I think it should be a tristate with "yes/no/ratelimit", and let's
default to ratelimit.

And I also suspect that we would be better off not returning an error
(which could make user space decide to break, either intentionally or
just because some people think that "error handling is important"
means that you should abort on all errors you don't recognize), but
just silently drop the write. IOW, the "no" would just be a rather
extreme form of rate-limiting, while "yes" would just be the other
extreme.

                   Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:00 +0200
  Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-25 21:10 +0200
    Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-25 21:20 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-25 21:30 +0200
        Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Andrew Morton <akpm@linux-foundation.org> - 2016-04-25 21:50 +0200
        Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-25 22:00 +0200
          Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 22:10 +0200
            Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 22:30 +0200
              Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 22:40 +0200
                Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 22:50 +0200
                Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 23:30 +0200
              Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-04-26 13:10 +0200
          Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-26 13:20 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:40 +0200
    Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 21:30 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:40 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 21:40 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:50 +0200
        Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Ingo Molnar <mingo@kernel.org> - 2016-04-26 07:40 +0200
          Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Bjørn Mork <bjorn@mork.no> - 2016-04-26 12:50 +0200
            Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-26 13:10 +0200
  Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Andi Kleen <andi@firstfloor.org> - 2016-04-25 21:50 +0200

csiph-web