Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386768

Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg
Date 2016-04-25 21:20 +0200
Message-ID <rrUd4-2DB-7@gated-at.bofh.it> (permalink)
References <rrTTI-2ag-17@gated-at.bofh.it> <rrU3o-2yD-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 25, 2016 at 09:06:51PM +0200, Peter Zijlstra wrote:
> On Mon, Apr 25, 2016 at 02:56:06PM -0400, Steven Rostedt wrote:
> > +static bool __read_mostly devkmsg_disabled;
> > +static int __init disable_devkmsg(char *str)
> > +{
> > +	devkmsg_disabled = true;
> > +	return 0;
> > +}
> > +__setup("printk.disable_kmsg_write", disable_devkmsg);
> 
> Again, please default enable and use an easier name to toggle this.
> Userspace flooding this with junk is really insane.

If you default enable, you break working systems today that want to log
stuff through this interface, sorry.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:00 +0200
  Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-25 21:10 +0200
    Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-25 21:20 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-25 21:30 +0200
        Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Andrew Morton <akpm@linux-foundation.org> - 2016-04-25 21:50 +0200
        Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-25 22:00 +0200
          Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 22:10 +0200
            Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 22:30 +0200
              Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 22:40 +0200
                Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 22:50 +0200
                Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 23:30 +0200
              Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-04-26 13:10 +0200
          Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-26 13:20 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:40 +0200
    Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 21:30 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:40 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-25 21:40 +0200
      Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-04-25 21:50 +0200
        Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Ingo Molnar <mingo@kernel.org> - 2016-04-26 07:40 +0200
          Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Bjørn Mork <bjorn@mork.no> - 2016-04-26 12:50 +0200
            Re: [PATCH v2] printk: Add kernel parameter to disable writes to  /dev/kmsg Peter Zijlstra <peterz@infradead.org> - 2016-04-26 13:10 +0200
  Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Andi Kleen <andi@firstfloor.org> - 2016-04-25 21:50 +0200

csiph-web