Groups > linux.kernel > #1382011

[PATCH 1/5] input: twl6040-vibra: fix DT node memory management

From	"H. Nikolaus Schaller" <hns@goldelico.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/5] input: twl6040-vibra: fix DT node memory management
Date	2016-04-18 22:00 +0200
Message-ID	<rpnuW-2F6-13@gated-at.bofh.it> (permalink)
References	<rpnuV-2F6-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

commit e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support")

made the separate vibra DT node to a subnode of the twl6040.

It now calls of_find_node_by_name() to locate the "vibra" subnode.
This function has a side effect to call of_node_put on() for the twl6040
parent node passed in as a parameter. This causes trouble later on.

Solution: we must call of_node_get() before of_find_node_by_name()

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 drivers/input/misc/twl6040-vibra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
index ea63fad..7221a00 100644
--- a/drivers/input/misc/twl6040-vibra.c
+++ b/drivers/input/misc/twl6040-vibra.c
@@ -262,6 +262,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
 	int vddvibr_uV = 0;
 	int error;
 
+	of_node_get(twl6040_core_dev->of_node);
 	twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node,
 						 "vibra");
 	if (!twl6040_core_node) {
-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] input: twl6040-vibra: fix DT node memory management "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-04-18 22:00 +0200
  Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-18 23:30 +0200
    Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-04-19 09:50 +0200
      Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-19 19:10 +0200
        Re: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-04-20 11:10 +0200

csiph-web