Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0

From	Sekhar Nori <nsekhar@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0
Date	2016-04-15 12:30 +0200
Message-ID	<ro9aF-1rh-5@gated-at.bofh.it> (permalink)
References	<rnBC1-8vj-1@gated-at.bofh.it> <rnBC2-8vj-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 14 April 2016 04:00 AM, David Lechner wrote:
> Adds device definition for soc spi0 and also a aux data that is needed
> for clock matching.
> 
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
>  arch/arm/boot/dts/da850.dtsi     | 10 ++++++++++
>  arch/arm/mach-davinci/da8xx-dt.c |  1 +
>  2 files changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index bbe7dd6..92b5f3c 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -295,6 +295,16 @@
>  			reg = <0x308000 0x80>;
>  			status = "disabled";
>  		};
> +		spi0: spi@41000 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			compatible = "ti,da830-spi";
> +			reg = <0x41000 0x1000>;
> +			num-cs = <6>;

This made me notice that num-cs is populated wrongly for spi1. It
actually has 8 chip selects. This is fine though.

Also, it will be nice to add pinctrl entries for spi0 like it is done
for spi1. You will need those anyway for using the interface.

> +			ti,davinci-spi-intr-line = <1>;
> +			interrupts = <20>;
> +			status = "disabled";
> +		};
>  		spi1: spi@30e000 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c
> index 64f3887..754f478 100644
> --- a/arch/arm/mach-davinci/da8xx-dt.c
> +++ b/arch/arm/mach-davinci/da8xx-dt.c
> @@ -28,6 +28,7 @@ static struct of_dev_auxdata da850_auxdata_lookup[] __initdata = {
>  	OF_DEV_AUXDATA("ti,da850-ecap", 0x01f06000, "ecap", NULL),
>  	OF_DEV_AUXDATA("ti,da850-ecap", 0x01f07000, "ecap", NULL),
>  	OF_DEV_AUXDATA("ti,da850-ecap", 0x01f08000, "ecap", NULL),
> +	OF_DEV_AUXDATA("ti,da830-spi", 0x01c41000, "spi_davinci.0", NULL),
>  	OF_DEV_AUXDATA("ti,da830-spi", 0x01f0e000, "spi_davinci.1", NULL),
>  	OF_DEV_AUXDATA("ns16550a", 0x01c42000, "serial8250.0", NULL),
>  	OF_DEV_AUXDATA("ns16550a", 0x01d0c000, "serial8250.1", NULL),

I prefer DT updates are patches of their own and not combined with code
updates like this. Can you please split this up?

Regards,
Sekhar

Thread

[PATCH 0/3] More small davinci device tree fixes David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
  [PATCH 3/3] ARM: DTS: da850: There are 101 interrupts. David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
    Re: [PATCH 3/3] ARM: DTS: da850: There are 101 interrupts. Sekhar Nori <nsekhar@ti.com> - 2016-04-15 12:30 +0200
  [PATCH 2/3] ARM: DTS: da850: disable mdio and eth0 by default David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
    Re: [PATCH 2/3] ARM: DTS: da850: disable mdio and eth0 by default Sekhar Nori <nsekhar@ti.com> - 2016-04-15 12:30 +0200
  [PATCH 1/3] ARM: DTS: da850: add node for spi0 David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
    Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 Sekhar Nori <nsekhar@ti.com> - 2016-04-15 12:30 +0200
      Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 David Lechner <david@lechnology.com> - 2016-04-15 18:20 +0200
        Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 Valdis.Kletnieks@vt.edu - 2016-04-15 22:20 +0200
          Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 David Lechner <david@lechnology.com> - 2016-04-15 23:30 +0200
        Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 Sekhar Nori <nsekhar@ti.com> - 2016-04-18 08:00 +0200
  Re: [PATCH 0/3] More small davinci device tree fixes Kevin Hilman <khilman@baylibre.com> - 2016-04-15 00:30 +0200

csiph-web