Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0

From	David Lechner <david@lechnology.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0
Date	2016-04-15 18:20 +0200
Message-ID	<roeDn-5Pa-5@gated-at.bofh.it> (permalink)
References	<rnBC1-8vj-1@gated-at.bofh.it> <rnBC2-8vj-33@gated-at.bofh.it> <ro9aF-1rh-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/15/2016 05:24 AM, Sekhar Nori wrote:

>
> This made me notice that num-cs is populated wrongly for spi1. It
> actually has 8 chip selects. This is fine though.

I might as well fix it since I have to make changes anyway. Don't 
remember how I came up with 6.

>
> Also, it will be nice to add pinctrl entries for spi0 like it is done
> for spi1. You will need those anyway for using the interface.

I omitted this on purpose. For my use case, I am using the SPI as 
write-only, so not using the SOMI pin, which is actually muxed as a GPIO 
for something else. So having a pinctl like spi1 is of no use to me. I 
figured if someone needs it, they can add it, otherwise it just is 
wasted space to me.
>
> I prefer DT updates are patches of their own and not combined with code
> updates like this. Can you please split this up?

Ack.

Thread

[PATCH 0/3] More small davinci device tree fixes David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
  [PATCH 3/3] ARM: DTS: da850: There are 101 interrupts. David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
    Re: [PATCH 3/3] ARM: DTS: da850: There are 101 interrupts. Sekhar Nori <nsekhar@ti.com> - 2016-04-15 12:30 +0200
  [PATCH 2/3] ARM: DTS: da850: disable mdio and eth0 by default David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
    Re: [PATCH 2/3] ARM: DTS: da850: disable mdio and eth0 by default Sekhar Nori <nsekhar@ti.com> - 2016-04-15 12:30 +0200
  [PATCH 1/3] ARM: DTS: da850: add node for spi0 David Lechner <david@lechnology.com> - 2016-04-14 00:40 +0200
    Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 Sekhar Nori <nsekhar@ti.com> - 2016-04-15 12:30 +0200
      Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 David Lechner <david@lechnology.com> - 2016-04-15 18:20 +0200
        Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 Valdis.Kletnieks@vt.edu - 2016-04-15 22:20 +0200
          Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 David Lechner <david@lechnology.com> - 2016-04-15 23:30 +0200
        Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0 Sekhar Nori <nsekhar@ti.com> - 2016-04-18 08:00 +0200
  Re: [PATCH 0/3] More small davinci device tree fixes Kevin Hilman <khilman@baylibre.com> - 2016-04-15 00:30 +0200

csiph-web