Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news.etla.org!aioe.org!bofh.it!news.nic.it!robomod
From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping
Date	Fri, 15 Apr 2016 11:20:04 +0200
Message-ID	<ro84Y-In-59@gated-at.bofh.it> (permalink)
References	<rmMga-8aY-15@gated-at.bofh.it> <rnStd-4TB-41@gated-at.bofh.it> <rnYoW-1cY-11@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RUC7vq37dOlSNd3R+RkJEMrYw08LYgG7CcLFPO9wM6E=; b=pjcmeYsm5cY3fpZpCCPy3GnMmskFtpTXdAJQEF3aERfM2n4Riz4i9Ig9uhV7uUpxRK Miu9t1E4DC+UFQnF1CBxOu7+ckwhSExmcDU10sIJmhxIls8PO9Pl2YWVx9IgfeHCB+b7 g473pPp8pwXNWQXMQnOQ0xJjM0ThHSt+tEgg1I8SxgCkIXAGygAi2KZ+3sWihZS8q0ku 7P9ROBtVfdRFek27aKOAZJ/SwMQEyu1ZqGJ1ZfOMgexbZa+AqLtaIc1Axq64l64i218L v6LGXLAQUGICYDmhwm+A/kHTKsa78db5xe2bLOeIpojoBwfZyN9dEnxdrjvhR5yVwl/j kaFg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=RUC7vq37dOlSNd3R+RkJEMrYw08LYgG7CcLFPO9wM6E=; b=cdjEvthTfoW+zQ+31A4kvrzB3V37k0hKVpW+SmnXtPmfEKCh4PqHe3G9OG3ZEwjAcg Qlj6qpK6rqDmf1BbxHgav23dHwPe5sx/RvPoBhlaEVWSmsQVj6Xp8vpCMwfxFiQF5P5W 34DYrCuuwB2LUNEB58TNO4D2swdIEY6PGaIkMCadRPhzBb4CF29VCi4h3PHmwl9O0+K5 O4OQyxYKidZOS5vDaK8nTPCb0c+ks0g6N7ZWkK0HQ6f7J26Cfr55yAsIPSyPgqGkkYwZ R38FwTi+fZygomIo/wYq33RY3zVezWBOenTmJh8CWxpQS9MAAx9l2BcX5gfk8EH8WE5O sn2w==
X-Gm-Message-State	AOPr4FXP89XxgPMA+/Af3Y8hv0fC6MN1L8gOIfSse1BOy4qZZY45o7u1H/VYzeke93fazQ==
X-Received	by 10.194.202.133 with SMTP id ki5mr20596762wjc.27.1460711942243; Fri, 15 Apr 2016 02:19:02 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	Dmitry Safonov <dsafonov@virtuozzo.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Dmitry Safonov <0x7f454c46@gmail.com>
X-Original-Date	Fri, 15 Apr 2016 11:18:59 +0200
X-Original-Message-ID	<20160415091859.GA10167@gmail.com>
X-Original-References	<1460388169-13340-1-git-send-email-dsafonov@virtuozzo.com> <1460651571-10545-1-git-send-email-dsafonov@virtuozzo.com> <CALCETrUhDvdyJV53Am2sgefyMJmHs5u1voOM2N76Si7BTtJWaQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1379609

Show key headers only | View raw

* Andy Lutomirski <luto@amacapital.net> wrote:

> > +       if (regs->ip == (unsigned long)current->mm->context.vdso +
> > +                       vdso_image_32.sym_int80_landing_pad
> > +#ifdef CONFIG_IA32_EMULATION
> > +               && current_thread_info()->status & TS_COMPAT
> > +#endif
> 
> Instead of ifdef, use the (grossly misnamed) is_ia32_task() helper for
> this, please.

Please also let's do the rename.

Thanks,

	Ingo

Thread

[PATCH] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-11 18:00 +0200
  [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-14 18:40 +0200
    Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-15 01:00 +0200
      Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Ingo Molnar <mingo@kernel.org> - 2016-04-15 11:20 +0200
        Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 12:00 +0200
          Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 14:10 +0200
  [PATCHv3 1/2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 15:30 +0200
    [PATCHv3 2/2] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 15:30 +0200
      Re: [PATCHv3 2/2] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Andy Lutomirski <luto@amacapital.net> - 2016-04-15 19:00 +0200
  [PATCHv4 2/2] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 16:30 +0200
  [PATCHv4 1/2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 16:30 +0200
    Re: [PATCHv4 1/2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-15 19:00 +0200
      Re: [PATCHv4 1/2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-18 17:40 +0200
  [PATCHv5 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 15:50 +0200
    Re: [PATCHv5 2/3] x86/vdso: add mremap hook to vm_special_mapping kbuild test robot <lkp@intel.com> - 2016-04-18 16:10 +0200
    [PATCHv6 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 16:20 +0200
    [PATCHv7 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 16:30 +0200
      Re: [PATCHv7 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-20 18:40 +0200
      Re: [PATCHv7 2/3] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-21 22:00 +0200
    Re: [PATCHv5 2/3] x86/vdso: add mremap hook to vm_special_mapping kbuild test robot <lkp@intel.com> - 2016-04-24 01:20 +0200
  [PATCHv5 1/3] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 15:50 +0200
    [PATCHv5 3/3] selftest/x86: add mremap vdso 32-bit test Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 15:50 +0200
      Re: [PATCHv5 3/3] selftest/x86: add mremap vdso 32-bit test Andy Lutomirski <luto@amacapital.net> - 2016-04-21 22:10 +0200
    [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() tip-bot for Dmitry Safonov <tipbot@zytor.com> - 2016-04-19 11:40 +0200
      Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() Ingo Molnar <mingo@kernel.org> - 2016-04-19 13:20 +0200
        Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() Borislav Petkov <bp@alien8.de> - 2016-04-19 13:40 +0200
          Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to in_{ia32,x32}_syscall() "H. Peter Anvin" <hpa@zytor.com> - 2016-04-19 19:10 +0200
        Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to in_{ia32,x32}_syscall() Andy Lutomirski <luto@amacapital.net> - 2016-04-19 18:10 +0200
          Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() Ingo Molnar <mingo@kernel.org> - 2016-04-22 10:40 +0200
  [PATCHv8 2/2] selftest/x86: add mremap vdso test Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-25 13:40 +0200
    Re: [PATCHv8 2/2] selftest/x86: add mremap vdso test Andy Lutomirski <luto@amacapital.net> - 2016-04-25 23:40 +0200
  [PATCHv8 1/2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-25 14:00 +0200
    Re: [PATCHv8 1/2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-25 23:40 +0200

csiph-web