Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1379609

Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping
Date 2016-04-15 11:20 +0200
Message-ID <ro84Y-In-59@gated-at.bofh.it> (permalink)
References <rmMga-8aY-15@gated-at.bofh.it> <rnStd-4TB-41@gated-at.bofh.it> <rnYoW-1cY-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Andy Lutomirski <luto@amacapital.net> wrote:

> > +       if (regs->ip == (unsigned long)current->mm->context.vdso +
> > +                       vdso_image_32.sym_int80_landing_pad
> > +#ifdef CONFIG_IA32_EMULATION
> > +               && current_thread_info()->status & TS_COMPAT
> > +#endif
> 
> Instead of ifdef, use the (grossly misnamed) is_ia32_task() helper for
> this, please.

Please also let's do the rename.

Thanks,

	Ingo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-11 18:00 +0200
  [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-14 18:40 +0200
    Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-15 01:00 +0200
      Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Ingo Molnar <mingo@kernel.org> - 2016-04-15 11:20 +0200
        Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 12:00 +0200
          Re: [PATCHv2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 14:10 +0200
  [PATCHv3 1/2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 15:30 +0200
    [PATCHv3 2/2] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 15:30 +0200
      Re: [PATCHv3 2/2] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Andy Lutomirski <luto@amacapital.net> - 2016-04-15 19:00 +0200
  [PATCHv4 2/2] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 16:30 +0200
  [PATCHv4 1/2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-15 16:30 +0200
    Re: [PATCHv4 1/2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-15 19:00 +0200
      Re: [PATCHv4 1/2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-18 17:40 +0200
  [PATCHv5 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 15:50 +0200
    Re: [PATCHv5 2/3] x86/vdso: add mremap hook to vm_special_mapping kbuild test robot <lkp@intel.com> - 2016-04-18 16:10 +0200
    [PATCHv6 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 16:20 +0200
    [PATCHv7 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 16:30 +0200
      Re: [PATCHv7 2/3] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-20 18:40 +0200
      Re: [PATCHv7 2/3] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-21 22:00 +0200
    Re: [PATCHv5 2/3] x86/vdso: add mremap hook to vm_special_mapping kbuild test robot <lkp@intel.com> - 2016-04-24 01:20 +0200
  [PATCHv5 1/3] x86: rename is_{ia32,x32}_task to in_{ia32,x32}_syscall Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 15:50 +0200
    [PATCHv5 3/3] selftest/x86: add mremap vdso 32-bit test Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-18 15:50 +0200
      Re: [PATCHv5 3/3] selftest/x86: add mremap vdso 32-bit test Andy Lutomirski <luto@amacapital.net> - 2016-04-21 22:10 +0200
    [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() tip-bot for Dmitry Safonov <tipbot@zytor.com> - 2016-04-19 11:40 +0200
      Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() Ingo Molnar <mingo@kernel.org> - 2016-04-19 13:20 +0200
        Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() Borislav Petkov <bp@alien8.de> - 2016-04-19 13:40 +0200
          Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to in_{ia32,x32}_syscall() "H. Peter Anvin" <hpa@zytor.com> - 2016-04-19 19:10 +0200
        Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to in_{ia32,x32}_syscall() Andy Lutomirski <luto@amacapital.net> - 2016-04-19 18:10 +0200
          Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to  in_{ia32,x32}_syscall() Ingo Molnar <mingo@kernel.org> - 2016-04-22 10:40 +0200
  [PATCHv8 2/2] selftest/x86: add mremap vdso test Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-25 13:40 +0200
    Re: [PATCHv8 2/2] selftest/x86: add mremap vdso test Andy Lutomirski <luto@amacapital.net> - 2016-04-25 23:40 +0200
  [PATCHv8 1/2] x86/vdso: add mremap hook to vm_special_mapping Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-25 14:00 +0200
    Re: [PATCHv8 1/2] x86/vdso: add mremap hook to vm_special_mapping Andy Lutomirski <luto@amacapital.net> - 2016-04-25 23:40 +0200

csiph-web