Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1378372

Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error
Date 2016-04-14 02:50 +0200
Message-ID <rnDDP-1uB-7@gated-at.bofh.it> (permalink)
References <rkorE-3JL-11@gated-at.bofh.it> <rlsCT-3LP-33@gated-at.bofh.it> <rlBPR-2jm-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04/08, Ralf Baechle wrote:
> 
> While your argument makes perfect sense, Many clk_disable implementations
> are already doing similar checks, for example:
> 
> arch/arm/mach-davinci/clock.c:
> 
[...]
> 
> So should we go and weed out these checks?

Yes, it would be nice to at least make the differing
implementations of the clk API consistent. Of course, we should
really put our efforts towards getting rid of the non-CCF
implementations instead so that there's less confusion overall.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-05 04:00 +0200
  Re: [PATCH v2] clk: let clk_disable() return immediately if clk is  NULL or error Stephen Boyd <sboyd@codeaurora.org> - 2016-04-08 02:40 +0200
    Re: [PATCH v2] clk: let clk_disable() return immediately if clk is  NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-08 04:00 +0200
      Re: [PATCH v2] clk: let clk_disable() return immediately if clk is  NULL or error Stephen Boyd <sboyd@codeaurora.org> - 2016-04-14 02:40 +0200
        Re: [PATCH v2] clk: let clk_disable() return immediately if clk is  NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-14 03:50 +0200
    Re: [PATCH v2] clk: let clk_disable() return immediately if clk is  NULL or error Ralf Baechle <ralf@linux-mips.org> - 2016-04-08 12:30 +0200
      Re: [PATCH v2] clk: let clk_disable() return immediately if clk is  NULL or error Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-08 13:20 +0200
      Re: [PATCH v2] clk: let clk_disable() return immediately if clk is  NULL or error Stephen Boyd <sboyd@codeaurora.org> - 2016-04-14 02:50 +0200

csiph-web