Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1378371

Re: [patch] ARM: qcom: silence an uninitialized variable warning

Show all headers | View raw

On 04/12/2016 11:45 PM, Dan Carpenter wrote:
> It's harmless but, if "enable" isn't set, then we pass uninitialized
> values to qcom_coincell_chgr_config().  The values aren't used, but
> let's silence the warning anyway.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/misc/qcom-coincell.c b/drivers/misc/qcom-coincell.c
> index 7b4a2da..829a61d 100644
> --- a/drivers/misc/qcom-coincell.c
> +++ b/drivers/misc/qcom-coincell.c
> @@ -94,7 +94,8 @@ static int qcom_coincell_probe(struct platform_device *pdev)
>  {
>  	struct device_node *node = pdev->dev.of_node;
>  	struct qcom_coincell chgr;
> -	u32 rset, vset;
> +	u32 rset = 0;
> +	u32 vset = 0;
>  	bool enable;
>  	int rc;
>  
> 
Looks OK to me.  Thanks for the warning cleanup!

Acked-by: Tim Bird
 -- Tim

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] ARM: qcom: silence an uninitialized variable warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-13 08:50 +0200
  Re: [patch] ARM: qcom: silence an uninitialized variable warning Tim Bird <tim.bird@sonymobile.com> - 2016-04-14 02:50 +0200
  Re: [patch] ARM: qcom: silence an uninitialized variable warning Arnd Bergmann <arnd@arndb.de> - 2016-04-14 04:00 +0200
    Re: [patch] ARM: qcom: silence an uninitialized variable warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-14 11:10 +0200

csiph-web