Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1376796

Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs

From Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups linux.kernel
Subject Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs
Date 2016-04-12 15:30 +0200
Message-ID <rn6ye-83Y-19@gated-at.bofh.it> (permalink)
References <qqnln-5Pq-11@gated-at.bofh.it> <rmVWb-7KC-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 04/11/2016 10:08 PM, Stefano Stabellini wrote:
> Hi all,
>
> Unfortunately this patch (now commit
> 8c058b0b9c34d8c8d7912880956543769323e2d8) causes a regression on Xen
> when running on top of QEMU: the number of PIT irqs get set to 0 by
> probe_8259A but actually there are 16.
>
> Any suggestions on how to fix this?
>
> 1) we could revert 8c058b0b9c34d8c8d7912880956543769323e2d8
> 2) we could introduce an 'if (!xen_domain())' in probe_8259A
> 3) suggestions welcome

Stefano, do you have b4ff8389ed14b849354b59ce9b360bdefcdbf99c ?

It was supposed to fix this problem for Xen. However, I just noticed 
that arch/arm64/include/asm/irq.h makes nr_legacy_irqs() return 0 
(unlike arch/arm/include/asm/irq.h). Could that be the problem?


-boris

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before  allocating descs for legacy IRQs Stefano Stabellini <sstabellini@kernel.org> - 2016-04-12 04:10 +0200
  Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-04-12 10:40 +0200
  Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-12 15:30 +0200
    Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Stefano Stabellini <sstabellini@kernel.org> - 2016-04-12 20:10 +0200
      Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-12 21:10 +0200
        Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Stefano Stabellini <sstabellini@kernel.org> - 2016-04-12 23:20 +0200
          Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-12 23:40 +0200
            Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-13 00:40 +0200
              Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Stefano Stabellini <sstabellini@kernel.org> - 2016-04-13 01:20 +0200
                Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-13 03:30 +0200
                Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-13 19:40 +0200
                Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-13 21:20 +0200
                Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-04-14 00:30 +0200
                Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Stefano Stabellini <sstabellini@kernel.org> - 2016-04-14 00:40 +0200
                Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-14 14:50 +0200
      Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs David Vrabel <david.vrabel@citrix.com> - 2016-04-14 15:50 +0200
        Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence  before allocating descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-14 16:50 +0200

csiph-web