Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1374261

[QUEUED v20160408 05/18] stm class: Remove a pointless line

From Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups linux.kernel
Subject [QUEUED v20160408 05/18] stm class: Remove a pointless line
Date 2016-04-08 17:00 +0200
Message-ID <rlG37-5o2-3@gated-at.bofh.it> (permalink)
References <rlG37-5o2-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


No point in explicitly setting something to zero right after we
explicitly checked that it is zero. Fix this.

Reported-by: Alan Cox <alan.cox@intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/stm/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index de80d45d8d..18f176eac0 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -546,8 +546,6 @@ static int stm_char_policy_set_ioctl(struct stm_file *stmf, void __user *arg)
 	if (ret)
 		goto err_free;
 
-	ret = 0;
-
 	if (stm->data->link)
 		ret = stm->data->link(stm->data, stmf->output.master,
 				      stmf->output.channel);
-- 
2.8.0.rc3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[QUEUED v20160408 05/18] stm class: Remove a pointless line Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-04-08 17:00 +0200

csiph-web