Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1374261 > unrolled thread

[QUEUED v20160408 05/18] stm class: Remove a pointless line

Started byAlexander Shishkin <alexander.shishkin@linux.intel.com>
First post2016-04-08 17:00 +0200
Last post2016-04-08 17:00 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [QUEUED v20160408 05/18] stm class: Remove a pointless line Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-04-08 17:00 +0200

#1374261 — [QUEUED v20160408 05/18] stm class: Remove a pointless line

FromAlexander Shishkin <alexander.shishkin@linux.intel.com>
Date2016-04-08 17:00 +0200
Subject[QUEUED v20160408 05/18] stm class: Remove a pointless line
Message-ID<rlG37-5o2-3@gated-at.bofh.it>
No point in explicitly setting something to zero right after we
explicitly checked that it is zero. Fix this.

Reported-by: Alan Cox <alan.cox@intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/stm/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index de80d45d8d..18f176eac0 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -546,8 +546,6 @@ static int stm_char_policy_set_ioctl(struct stm_file *stmf, void __user *arg)
 	if (ret)
 		goto err_free;
 
-	ret = 0;
-
 	if (stm->data->link)
 		ret = stm->data->link(stm->data, stmf->output.master,
 				      stmf->output.channel);
-- 
2.8.0.rc3

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web