Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

From	Henrik Rydberg <rydberg@bitmath.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data
Date	2016-04-06 22:00 +0200
Message-ID	<rl1Mm-uH-7@gated-at.bofh.it> (permalink)
References	(4 earlier) <rjfgL-1XC-33@gated-at.bofh.it> <rjxdE-70V-23@gated-at.bofh.it> <rkX61-5pE-5@gated-at.bofh.it> <rkZAT-7uO-23@gated-at.bofh.it> <rl0ZX-aA-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Aniroop,

>> I am not sure what the urgency is. It is more of a theoretical problem
>> ans so far the proposed solutions were actually introducing more
>> problems than they were solving.
>>
>> I am sorry, bit this particular topic is not a priority for me.
>>
> 
> There is no hurry at all. :-) As you know request is made a long time ago,
> so I am only very curious to complete it.

This kind of patch is not liked by any maintainer, because it does not solve any
immediate problem, but instead may create one. If such a simple patch takes
three of four tries to look right, it only adds to the perception that the code
is best left alone.

I think the solution at this stage is to say no to this patch.

If there is ever a driver for which the input_estimate_events_per_packet()
function returns less than the actual maximum number of events per frame, this
issue can be revisited and resolved in a number of different ways.

Sorry, and thanks for your work.

Henrik

Thread

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-02 19:10 +0200
  [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <a.mathur@samsung.com> - 2016-04-04 19:30 +0200
  Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-06 17:00 +0200
    Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet  data Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-06 19:40 +0200
      Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-06 21:10 +0200
        Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet  data Henrik Rydberg <rydberg@bitmath.org> - 2016-04-06 22:00 +0200
          Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-04-06 22:50 +0200

csiph-web